Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): send form feedback from new contact view via Sentry #1733

Merged
merged 12 commits into from
Oct 4, 2023

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Sep 30, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/www/app/platform.ts 100% <ø> (ø)
src/www/views/contact_view/index.ts 92% <100%> (-1%) ⬇️
src/www/views/contact_view/support_form/index.ts 88% <100%> (ø)
src/www/app/app.ts 8% <0%> (-1%) ⬇️
src/www/shared/error_reporter.ts 17% <44%> (ø)
src/www/ui_components/app-root.js 4% <0%> (-1%) ⬇️

📢 Thoughts on this report? Let us know!.

@sbruens sbruens marked this pull request as ready for review September 30, 2023 02:41
@sbruens sbruens requested a review from a team as a code owner September 30, 2023 02:41
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just need to align on what "infrastructure" means, the rest is just nits

src/www/app/app.ts Outdated Show resolved Hide resolved
src/www/app/app.ts Outdated Show resolved Hide resolved
src/www/app/electron_main.ts Outdated Show resolved Hide resolved
src/www/ui_components/app-root.js Show resolved Hide resolved
src/www/views/contact_view/index.ts Outdated Show resolved Hide resolved
src/www/views/contact_view/index.ts Outdated Show resolved Hide resolved
@sbruens sbruens requested a review from daniellacosse October 2, 2023 16:10
@sbruens sbruens force-pushed the sbruens/send-feedback branch from 18c0b17 to 8f14ff4 Compare October 2, 2023 17:01
@sbruens sbruens merged commit 08b09ee into master Oct 4, 2023
17 checks passed
@sbruens sbruens deleted the sbruens/send-feedback branch October 4, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants