-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move tools to src/tools #1729
Conversation
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It helpful to check if the Electron apps still work well, and that we can still build their native components.
Perhaps @jyyi1 can help.
This is good, incremental progress. I see two simple follow-ups to this PR
|
Is this PR blocked on anything? |
I think you wanted @jyyi1 to verify? |
It doesn't have to be @jyyi1 . If you can validate at least that we can build the native components for all platforms, it should be fine. QA can catch if there was an issue with the functionality, but ideally we would check that too. |
I don't really see the point to be honest - we had to revert the |
No description provided.