feat(www): add OS and version information to the contact view data form

[sbruens]

No description provided.

[sbruens]

@daniellacosse Where do you think shared / utility libraries should live? I don't think this should live here but there's no clear better place to put these right now. Any preferences?

[daniellacosse]

infrastructure!

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
src/www/ui_components/app-root.js	4% <ø> (ø)
src/www/views/contact_view/os.ts	100% <100%> (ø)
src/www/views/contact_view/support_form/index.ts	88% <ø> (ø)
src/www/views/contact_view/index.ts	88% <50%> (-6%)	⬇️

📢 Thoughts on this report? Let us know!.

[daniellacosse]

We should add this to infrastructure as well!

What's your rationale behind separating the boolean constants and the strings? Why not just a getOperatingSystemValue that returns an enum/string union?

[sbruens]

This is specific to the form values that Salesforce expects. They shouldn't be re-used elsewhere. In fact, I'm going to update them once I get the correct API values.

I went with a boolean as its a fairly common pattern for this type of check; it's slightly more efficient, but mostly it allows for more readable re-use if we want to use it elsewhere. Compare:

if (IS_ANDROID) {
  doSomething():
}

if (getOperatingSystemValue() === OperatingSystem.ANDROID) {
  doSomething();
}

I could created a shared infrastructure function that returns an enum, and then map the enum values to the form strings as a second step. Seems a bit more convoluted though, so I'm hesitant to add it just for the sake of it? But I can be convinced.

[daniellacosse]

Yes I do find the whole approach a bit anemic - ideally we'd have a UserAgent singleton class that has these methods on it e.g.

const agent = new UserAgent();

agent.isAndroid();

which could then be extended later

[daniellacosse]

infrastructure!

[sbruens]

Going to abandon this PR after doing some more exploring. Version, OS, and build are already available elsewhere.