integrated reboot-cause history into reboot tests in platfrom_tests/test_reboot.py #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JibinBao
changed the title
JibinBao
changed the title
keboliu
reviewed
Sep 13, 2021
tests/common/reboot.py
Outdated
| logging.debug("Check reboot-cause history title") | ||
| if reboot_cause_history_got: | ||
| if not set(REBOOT_CAUSE_HISTORY_TITLE) == set(reboot_cause_history_got[0].keys()): | ||
| logging.debug("Expected reboot-cause history:{} not match actual reboot-cause history:{}".format( |
There was a problem hiding this comment.
should this log always be printed to give users a hint about the failure reason? Same comments to the below two debug logging.
There was a problem hiding this comment.
Yes, I will change it to error level
JibinBao
force-pushed
the
add_reboot_cause_history_platform
branch
from
034f9f7 to
f8100cc
Compare
keboliu
approved these changes
Sep 13, 2021
|
open external PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Since adding the feature(sonic-net/SONiC#669) of show reboot-cause history, so integrate "show reboot-cause history" into sonic-mgmt/tests/platform_tests/test_reboot.py.
e.g.
Type of change
Back port request
Approach
What is the motivation for this PR?
In order to verify reboot-cause history function, add new checker for "show reboot-cause history" into reboot tests
How did you do it?
Add one new function of check_reboot_cause_history in sonic-mgmt/tests/platform_tests/test_reboot.py.
In test_reboot.py, there are 8 different reboot tests. In order to save test execution time, we leverage the reboot-cause history generated by them to test it.
How did you verify/test it?
run test_reboot.py
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
sonic-net/SONiC#669