Add option to allow degenerated grid cells #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #60
By using
xe.Regridder(grid_in, grid_out, 'conservative', ignore_degenerate=True)
, ESMF won't throw an error when seeing degenerated cells like triangles. But it might givenan
for such cells. Should probably still throw an error by default, as this helps detecting bad/illegal grid coordinates. Ref: #22 (comment).@bradyrx could you see whether this works properly for your problem?
TODO:
Welcome to contribute test cases.