Make GetMatcherWhereClause static and move IGroupedElement

The method GetMatcherWhereClause in RavenJobStore.Utils has been made static. Furthermore, the IGroupedElement interface has been moved from Job.cs to its own file to improve code organization and readability.
JezhikLaas · Dec 20, 2023 · 5a0dd94 · 5a0dd94
1 parent ab88e1d
commit 5a0dd94
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/Quartz.Impl.RavenJobStore/Entities/IGroupedElement.cs b/Quartz.Impl.RavenJobStore/Entities/IGroupedElement.cs
@@ -0,0 +1,6 @@
+namespace Domla.Quartz.Raven.Entities;
+
+internal interface IGroupedElement
+{
+    string Group { get; }
+}
diff --git a/Quartz.Impl.RavenJobStore/Entities/Job.cs b/Quartz.Impl.RavenJobStore/Entities/Job.cs
@@ -59,11 +59,6 @@ public IJobDetail? Item
     }
 }
 
-internal interface IGroupedElement
-{
-    string Group { get; set; }
-}
-
 internal static class JobKeyExtensions
 {
     public static string GetDatabaseId(this JobKey? jobKey, string schedulerName) => 

diff --git a/Quartz.Impl.RavenJobStore/RavenJobStore.Utils.cs b/Quartz.Impl.RavenJobStore/RavenJobStore.Utils.cs
@@ -403,7 +403,7 @@ select trigger
         result.ForEach(x => buffer.Enqueue(x, -x.Priority));
     }
 
-    private (bool clientMatch, IRavenQueryable<T>) GetMatcherWhereClause<T, TKey>(
+    private static (bool clientMatch, IRavenQueryable<T>) GetMatcherWhereClause<T, TKey>(
         IRavenQueryable<T> source,
         GroupMatcher<TKey> matcher) where T : IGroupedElement where TKey : Key<TKey> 
     {