Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.0.2 introduced some bad typo #103

Closed
shustariov-andrey opened this issue May 4, 2017 · 6 comments
Closed

v2.0.2 introduced some bad typo #103

shustariov-andrey opened this issue May 4, 2017 · 6 comments
Milestone
2.1

Comments

@shustariov-andrey
Copy link

https://github.com/kisenka/svg-sprite-loader/blob/v2.0.2/examples/browser-sprite/build/main.js#L600

window.localtion.href - should be window.location.href
@shustariov-andrey
Copy link
Author

My bad, actually, it is there since the beginning

@kisenka
Copy link
Contributor

kisenka commented May 10, 2017 •
edited
Loading

Fixed in svg-baker-runtime@1.2.94, please update

@shustariov-andrey
Copy link
Author

Didn't help. Still seeing broken browser-sprite.build.js in svg-sprite-loader/runtime folder. Did rm -Rf node_modules and npm i. Used "svg-sprite-loader": "2.1.0-2"

@kisenka
Copy link
Contributor

kisenka commented May 10, 2017

Pinged you in hanguots

@kisenka kisenka modified the milestone: 2.1 May 11, 2017
kisenka added a commit that referenced this issue May 13, 2017
@kisenka
fix(multiple): update svg-baker deps
ead7d68 
closes #101, closes #103, closes #112
@kisenka
Copy link
Contributor

kisenka commented May 13, 2017

Fixed in svg-sprite-loader@2.1.0

@shustariov-andrey
Copy link
Author

Yep, can confirm the fix, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
2 participants
@kisenka @shustariov-andrey