Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Filter absent problems and add a test on ignoring absent and unchanged problems #436

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

AndreiIurko
Copy link
Contributor

@AndreiIurko AndreiIurko commented Jan 13, 2025

This pull request includes several changes to improve the handling of SARIF files and update versioning information. The most important changes include adding new test cases, updating the SARIF parsing logic, and updating the version in the manifest file.

Improvements to SARIF handling:

  • scan/__tests__/main.test.ts: Added a new test case to check the output annotations for SARIF files with problems and a baseline.
  • scan/src/annotations.ts: Updated the parseSarif function to filter out results with a baseline state of 'absent' in addition to 'unchanged'.

Versioning update:

@AndreiIurko AndreiIurko requested a review from tiulpin as a code owner January 13, 2025 10:36
Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@tiulpin tiulpin changed the title Iurko/filter absent 🐛 Filter absent problems and add a test on ignoring absent and unchanged problems Jan 13, 2025
@tiulpin tiulpin merged commit 79afc8e into main Jan 13, 2025
83 checks passed
@tiulpin tiulpin deleted the iurko/filter-absent branch January 13, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants