Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writeside Migration (Test PR) #371

Closed

Conversation

Quattro8
Copy link
Contributor

@Quattro8 Quattro8 commented Sep 6, 2024

No description provided.

@ndkoval
Copy link
Collaborator

ndkoval commented Sep 9, 2024

Hi @Quattro8, thanks for the WriterSide update! Is it possible to check that these changes do not break the documentation before merging the PR?

@Quattro8
Copy link
Contributor Author

Quattro8 commented Sep 9, 2024

@ndkoval hi, it is just the test PR.

We've already checked the docs themselves (we built them and published to the staging). Also it is possible to use my fork to open the migrated docs in WRS and check all what you need

@ndkoval
Copy link
Collaborator

ndkoval commented Sep 9, 2024

@Quattro8 Thanks for performing the check! What do you mean by "test PR"?

It's unclear what the "test PR" means here. Should we ignore and close it, or should we merge it?

@Quattro8
Copy link
Contributor Author

Quattro8 commented Sep 9, 2024

@ndkoval just ignore it) it contains a list of changes that will be applied in the migration day (25 of September)

@ndkoval
Copy link
Collaborator

ndkoval commented Sep 25, 2024

This is a test PR. The changes are merged under #385.

@ndkoval ndkoval closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants