Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In FieldSearchHelper skip protected or private fields that cannot be read by Unsafe #367

Merged
merged 4 commits into from
Sep 2, 2024
Merged

In FieldSearchHelper skip protected or private fields that cannot be read by Unsafe #367

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ce57bb
in FieldSearchHelper skip protected fields that cannot be read by Unsafe
eupp Aug 8, 2024
b918425
ignore hidden and record classes in `FieldSearchHelper.kt`
eupp Aug 29, 2024
9e9fa69
skip hidden fields via `runCatching`
eupp Aug 30, 2024
fd9517c
add a comment
eupp Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/FieldSearchHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,13 @@ internal object FieldSearchHelper {
// so there is no problem that we can receive some fields of the same name and the same type.
for (field in testObject::class.java.allDeclaredFieldWithSuperclasses) {
if (field.type.isPrimitive) continue
val fieldValue = readFieldViaUnsafe(testObject, field, Unsafe::getObject)

// We wrap an unsafe read into `runCatching` to hande `UnsupportedOperationException`,
// which can be thrown, for instance, when attempting to read a field of
// a hidden class (starting from Java 15).
val fieldValue = runCatching {
readFieldViaUnsafe(testObject, field, Unsafe::getObject)
}.getOrNull() ?: continue

if (fieldValue in visitedObjects) continue
visitedObjects += testObject
Expand Down