Improve trace representation: show non-this object instances on method calls and show field names when using VarHandle, AtomicReference, andUnsafe
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…micReference methods trace points made more readable.
ndkoval
requested changes
May 8, 2024
| LincheckJavaAgent.ensureObjectIsTransformed(testInstance) | ||
| ensuredTestInstanceIsTransformed = true | ||
| if (strategy is ModelCheckingStrategy) { | ||
| strategy.initializeCallStack(testInstance) |
There was a problem hiding this comment.
With this change, the comment above is incorrect.
There was a problem hiding this comment.
Besides, it's unclear what this call does and why you need it in the runner.
There was a problem hiding this comment.
Why is this logic added to Runner instead of ManagedStrategy.initializeInvocation?
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/AtomicFieldUpdaterNames.kt
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/transformation/LincheckClassVisitor.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/util/UnsafeHolder.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/TraceReporter.kt
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ObjectNumerator.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Show resolved
Hide resolved
src/jvm/test/resources/expected_logs/varhandle_representation.txt
Outdated
Show resolved
Hide resolved
added 4 commits
May 8, 2024 17:38
ndkoval
requested changes
May 8, 2024
| LincheckJavaAgent.ensureObjectIsTransformed(testInstance) | ||
| ensuredTestInstanceIsTransformed = true | ||
| if (strategy is ModelCheckingStrategy) { | ||
| strategy.initializeCallStack(testInstance) |
There was a problem hiding this comment.
Why is this logic added to Runner instead of ManagedStrategy.initializeInvocation?
|
|
||
| private fun simpleClassName(className: String) = className.takeLastWhile { it != '/' } | ||
|
|
||
| private fun initializeUnsafeMethodCallTracePoint( |
There was a problem hiding this comment.
Initialize because it's created previously in the common logic part.
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt
Show resolved
Hide resolved
ndkoval
approved these changes
May 8, 2024
There was a problem hiding this comment.
I approve the PR, but we need to address the remaining comments. @avpotapov00
ndkoval
changed the title
this object instances on method calls and show field names when using VarHandle, AtomicReference, andUnsafe
ndkoval
deleted the
320-show-object-identifiers-when-calling-methods-or-manipulating-fields-on-non-this-instances
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #315 , #317 , #320 and #324