Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserved keyword on ? #264

Closed
smeevil opened this issue Jul 1, 2019 · 6 comments
Closed

Reserved keyword on ? #264

smeevil opened this issue Jul 1, 2019 · 6 comments

Comments

@smeevil
Copy link

smeevil commented Jul 1, 2019

It seems that on is handled as a reserved keyword. I'm not sure if this is actually the case, but I could not find any information about graphql schemas and reserved keywords.

Operation system: macOS Mojave 10.14.5

IDE name and version: IntelliJ 2019.2 EAP

Plugin version: 2.2.0

Expected Behaviour

Given the following schema.graphql snippet :

type Foo {
  bar(on: Date): [Baz!]!
}

I would expect the on to be regarded as a regular variable.

Actual Behaviour

It now throws with unexpected token 'on'
If I rename the on variable to onn for example, it parses fine.

@PowerKiKi
Copy link

This seems to be a duplicate of #239

@smeevil
Copy link
Author

smeevil commented Sep 9, 2019

Hi,

I was wondering if this is still on the radar?

@jimkyndemeyer
Copy link
Collaborator

I plan on fixing this eventually, but It depends on a similar fix in graphql-java 14.0 which hasn't been released yet.

@smeevil
Copy link
Author

smeevil commented Sep 9, 2019

Thanks for getting back, I'll practice some more patience :)

jimkyndemeyer added a commit that referenced this issue Mar 13, 2020
- Upgraded graphql-java to 14.0 (graphql-java/graphql-java#1523)
- Refactored breaking changes from graphql-java 12.0 to 14.0
@jimkyndemeyer
Copy link
Collaborator

Fixed in the upcoming 2.4.0.

@smeevil
Copy link
Author

smeevil commented Mar 13, 2020

awesome ! thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants