Tune logging #704
Merged
Tune logging #704
+20
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was commented out and committed by mistake. This should make it less noisy and somewhat opt-in.
This reduces the amount of "spam" due to ResourcePainterProvider. For now the user needs to patch the logger factory by hand, but we should introduce a way to configure this — see #703
hamen
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uncomments logging in
ResourcePainterProviderwhich should never have been committed to begin with, and adjusts its level to trace (FINER). It also sets theJavaFactorylevel toFINE(debug), so thatResourcePainterProvider's logs don't spam the console. Lastly, it cleans upJewelLogger's code with the IDE's Clean up action