Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup after dividers #700

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Fixup after dividers #700

merged 5 commits into from
Nov 25, 2024

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Nov 25, 2024

This PR:

  • Cleans up missing dividers after Remove fillMax* from Divider to avoid glitches and edge-cases #699 (not all our Dividers were specifying their size)
  • Fixes thematic breaks (aka <hr>) rendering in Markdown — they were simply not shown
  • Fixes the preset selection dropdown in the standalone sample's Markdown page, which was very very broken (selecting a preset would load it, but also make the entire sample app not respond anymore; it also looked ugly)

@rock3r rock3r added the cleanup Improve the project/tooling and/or get rid of tech debt label Nov 25, 2024
@rock3r rock3r requested a review from hamen November 25, 2024 14:31
@rock3r rock3r self-assigned this Nov 25, 2024
@rock3r rock3r enabled auto-merge (squash) November 25, 2024 14:32
@rock3r rock3r merged commit 0b5c26d into main Nov 25, 2024
1 check passed
@rock3r rock3r deleted the fixup-after-dividers branch November 25, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamen hamen hamen approved these changes

Assignees

@rock3r rock3r

Labels
cleanup Improve the project/tooling and/or get rid of tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rock3r @hamen