Banners #688
Merged
Banners #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
rock3r
reviewed
Nov 18, 2024
.../standalone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/view/component/Banners.kt
Outdated
Show resolved
Hide resolved
hamen
force-pushed
the
im-611-default-banner
branch
from
b4ef77d to
f414cc7
Compare
rock3r
approved these changes
Nov 25, 2024
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
* add InformationBanner PoC Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * remove unnecessary LocalOutlinedBannerStyle Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * rework InformationBanner Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * add InformationBanner theme and showcase for IDE Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * make formatter and linter happy * rework BannerColors and add SuccessBanner Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * make formatter and linter happy * fix typo in ComponentsShowcaseTab2 Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * split factories in IntUIBannerStyling reference #689 (comment) Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * skip icon area when icon is null reference #689 (comment) Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * fix old string in BannerStyling reference #689 (comment) Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * remove fillMaxWidth from BannerImpl reference #689 (comment) Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * make formatter and linter happy --------- Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
* add InformationBanner PoC Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * rework InformationBanner Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * add InformationBanner theme and showcase for IDE Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * make formatter and linter happy * fix typo in ComponentsShowcaseTab2 Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * add WarningBanner Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * add ErrorBanner Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * fix wrong region comment syntax Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * check for null actions in Action slot API Signed-off-by: Ivan Morgillo <imorgillo@gmail.com> * make formatter and linter happy --------- Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
|
Actually, the banner border are missing after #699, so undoing the approval for now |
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
hamen
force-pushed
the
im-611-default-banner
branch
from
265b965 to
3e97adb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #611