Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ijp 243 #628

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Move to ijp 243 #628

merged 1 commit into from
Oct 15, 2024

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2024

No description provided.

@ghost ghost requested a review from rock3r October 14, 2024 11:46
@rock3r rock3r assigned ghost Oct 14, 2024
@rock3r rock3r added the maintenance Rote maintenance tasks (e.g., dependency updates) label Oct 14, 2024
ideaPlugin = "2.1.0"
jna = "5.14.0"
kotlin = "1.9.24"
kotlin = "2.0.10"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm this is the IJP version? The documentation is outdated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like 2.0.21-rc, but I am not sure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsz do you know by any chance?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-checked and indeed the intellij in latest master uses 2.0.21-RC

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like you updated the Kotlin version here accordingly tho

@ghost ghost force-pushed the move-to-ijp-243 branch 3 times, most recently from 56a865c to 66b22a5 Compare October 15, 2024 11:06
ideaPlugin = "2.1.0"
jna = "5.14.0"
kotlin = "1.9.24"
kotlin = "2.0.10"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like you updated the Kotlin version here accordingly tho

This includes:
 * Migrating SwingBridgeService to LafFlowService
 * Bumping IJP platform to 243
 * Targeting theme gen to 243.19420.21
 * Bumping to Kotlin 2.0
 * Switching to the new Compose Compiler Gradle plugin
 * Bumping Poko, KotlinPoet, kotlinx-serialization
 * Bumping kotlinx-binary-compatibility-validator
 * Pre-emptively bumping Jewel to 0.25.0
@ghost ghost force-pushed the move-to-ijp-243 branch from 66b22a5 to 47c7d63 Compare October 15, 2024 12:24
@rock3r rock3r merged commit bf8bc5a into main Oct 15, 2024
1 check passed
@rock3r rock3r deleted the move-to-ijp-243 branch October 15, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Rote maintenance tasks (e.g., dependency updates)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant