Fix z-order for text field/area placeholder #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the order in which the placeholder and actual text field are laid out in the TextField and TextArea code. Since the two have the same zIndex (the default value, 0f) their placement order is reflected in the drawing order: the last placed is drawn last, on top of the rest. This fixes a minor cosmetic issue, where the placeholder would be drawn on top of the cursor when the TextArea/TextField is empty.
hamen
approved these changes
Sep 30, 2024
|
Thank you!! |
|
You're welcome 🤗 it's available in 0.25 |
|
Is jewel 0.25 compatible with IJ 241? Just want to make sure. |
github-merge-queue bot
pushed a commit
to slackhq/foundry
that referenced
this pull request
Sep 30, 2024
I had an issue with the placeholder being in front of the cursor text and spoke with Sebastiano from Jewel about it. He ended up filing this issue: JetBrains/jewel#610 which got resolved here JetBrains/jewel#615, which is available in Jewel 0.25. This passes checks and the text area looks nicer now: Before: <img width="331" alt="Screenshot 2024-09-30 at 4 13 06 PM" src="https://github.com/user-attachments/assets/9827ece9-07f5-4e08-a599-b9dcb2232e05"> After: <img width="331" alt="Screenshot 2024-09-30 at 4 13 35 PM" src="https://github.com/user-attachments/assets/027a0ed4-b681-4428-a028-5370ccc35579"> <!-- ⬆ Put your description above this! ⬆ Please be descriptive and detailed. Please read our [Contributing Guidelines](https://github.com/tinyspeck/foundry/blob/main/.github/CONTRIBUTING.md) and [Code of Conduct](https://slackhq.github.io/code-of-conduct). Don't worry about deleting this, it's not visible in the PR! -->
|
Yes. Just make sure you use the -241 artefacts. The supported IJP versions table in the readme is up to date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the order in which the placeholder and actual text field are laid out in the TextField and TextArea code. Since the two have the same zIndex (the default value, 0f) their placement order is reflected in the drawing order: the last placed is drawn last, on top of the rest.
This fixes a minor cosmetic issue, where the placeholder would be drawn on top of the cursor when the TextArea/TextField is empty.
Fixes #610