Fixed Text Component order for color #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rock3r
approved these changes
Sep 17, 2024
rock3r
pushed a commit
that referenced
this pull request
Sep 24, 2024
Fixed Null Pointer in IDE sample on non INTUI themes Co-authored-by: Francisco Noriega <francisco.noriega@airbnb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #591
Reverts Text component logic for getting the color to one that matches Material, which is one that respects the caller's passed in parameters first (color, then the color in the textStyle), and then falls back to localContentColor.
The code originally used what I propose here, but was later swapped to solve a bug with Tooltip + LightTheme: https://github.com/JetBrains/jewel/pull/180/files#r1361761781, but I believe this is the correct fix.
I tested that tooltip still works on ide + standalone, on light and dark