Fix TextField placeholder going outside the bounds of the TextField #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that we were not capping the size of the placeholder when measuring it; but the placeholder can't be larger than the space allocated to the actual text; setting the constraints accordingly fixes the issue.
hamen
approved these changes
Aug 29, 2024
slack-oss-bot
referenced
this pull request
in slackhq/foundry
Sep 1, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.jetbrains.jewel:jewel-int-ui-standalone-241](https://redirect.github.com/JetBrains/jewel) | dependencies | patch | `0.23.0` -> `0.23.1` | | [org.jetbrains.jewel:jewel-ide-laf-bridge-241](https://redirect.github.com/JetBrains/jewel) | dependencies | patch | `0.23.0` -> `0.23.1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>JetBrains/jewel (org.jetbrains.jewel:jewel-int-ui-standalone-241)</summary> ### [`v0.23.1`](https://redirect.github.com/JetBrains/jewel/releases/tag/v0.23.1) ##### Notable changes: - Fixed an issue where the placeholder text in `TextField` could extend beyond the boundaries of the `TextField` itself. ##### What's Changed - Fix TextField placeholder going outside the bounds of the TextField by [@​rock3r](https://redirect.github.com/rock3r) in [https://github.com/JetBrains/jewel/pull/567](https://redirect.github.com/JetBrains/jewel/pull/567) **Full Changelog**: JetBrains/jewel@v0.23.0...v0.23.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OC4wIiwidXBkYXRlZEluVmVyIjoiMzguNTguMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that we were not capping the size of the placeholder when measuring it; but the placeholder can't be larger than the space allocated to the actual text; setting the constraints accordingly fixes the issue.