Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterate on TextField and TextArea focused state UI #540

Merged
merged 22 commits into from
Aug 26, 2024
Merged

Iterate on TextField and TextArea focused state UI #540

merged 22 commits into from
Aug 26, 2024

Conversation

hamen
Copy link
Collaborator

@hamen hamen commented Aug 13, 2024 •
edited
Loading

Description

This PR iterates on consistency issues on buttons, textfields and textareas.

Related Issue

#463

#541, please review this in #543.

Checklist

  • I have executed the API dump and Reformat project Gradle tasks
  • I have performed a self-review of my code
  • My changes generate no new warnings

How Has This Been Tested?

  • I have manually tested my changes on macOS
    • dark
    • light
  • I have manually tested my changes on Windows
    • dark
    • light
  • I have manually tested my changes on Linux
    • dark
    • light

Screenshots or GIFs:

Standalone

image
image
image
image
image

IDE

image
image
image
image
image
image
image

@hamen hamen self-assigned this Aug 13, 2024
This was linked to issues Aug 13, 2024
Ensure TextField and TextArea decoration looks correct #463
Closed
Alignment issue with outlined button #541
Closed
@hamen hamen requested a review from rock3r August 13, 2024 14:58
@hamen hamen marked this pull request as ready for review August 13, 2024 14:59
@rock3r
Copy link
Collaborator

rock3r commented Aug 14, 2024

Looking at the screenshots, it looks like:

  • in standalone the corner radius is too large when focused (both text area and text field) — the value may be correct, but not the alignment of border + outline
  • the text area paddings are wrong in this screenshot — is it outdated?

The screenshots of the buttons are not enough to compare and see if they're correct.

In general, in the future please don't title a PR as containing one fix when the PR fixes two separate and independent issues. I'd much rather have separate PRs for separate fixes, which obviates the problem.

@hamen
Copy link
Collaborator Author

hamen commented Aug 14, 2024 •
edited
Loading

Looking at the screenshots, it looks like:

  • in standalone the corner radius is too large when focused (both text area and text field) — the value may be correct, but not the alignment of border + outline

I'll look into it.

  • the text area paddings are wrong in this screenshot — is it outdated?

Wrong paste. I have updated it.
image

The screenshots of the buttons are not enough to compare and see if they're correct.

In general, in the future please don't title a PR as containing one fix when the PR fixes two separate and independent issues. I'd much rather have separate PRs for separate fixes, which obviates the problem.

I'll split the two PRs and provide more screenshots.

@rock3r rock3r added the consistency Our UI presentation is not consistent with IJ label Aug 19, 2024
rock3r
rock3r requested changes Aug 19, 2024
View reviewed changes
hamen added a commit that referenced this pull request Aug 19, 2024
@hamen
remove detekt-compose dependency from .idea/detect.xml
d5c7139 
reference: #540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen hamen marked this pull request as draft August 19, 2024 09:23
hamen added a commit that referenced this pull request Aug 19, 2024
@hamen
remove redundant parameter in IntUiBridge TextFieldMetrics
26c91bf 
reference: #540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
hamen added a commit that referenced this pull request Aug 19, 2024
@hamen
remove detekt-compose dependency from .idea/detect.xml
a065a19 
reference: #540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
hamen added a commit that referenced this pull request Aug 19, 2024
@hamen
remove redundant parameter in IntUiBridge TextFieldMetrics
7242fce 
reference: #540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen hamen force-pushed the im-463-tuning-textfields-ui branch from b610f03 to 59020d8 Compare August 19, 2024 13:18
@hamen hamen marked this pull request as ready for review August 19, 2024 13:19
@hamen hamen requested a review from rock3r August 19, 2024 13:19
@rock3r
Copy link
Collaborator

rock3r commented Aug 19, 2024

Conflicts to solve here, too

hamen added a commit that referenced this pull request Aug 20, 2024
@hamen
remove detekt-compose dependency from .idea/detect.xml
f243704 
reference: #540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
hamen added a commit that referenced this pull request Aug 20, 2024
@hamen
remove redundant parameter in IntUiBridge TextFieldMetrics
693b9e4 
reference: #540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen hamen force-pushed the im-463-tuning-textfields-ui branch from 59020d8 to d8182f6 Compare August 20, 2024 17:10
hamen added a commit that referenced this pull request Aug 20, 2024
@hamen
remove detekt-compose dependency from .idea/detect.xml
91956c3 
reference: #540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
hamen added a commit that referenced this pull request Aug 20, 2024
@hamen
remove redundant parameter in IntUiBridge TextFieldMetrics
134b8ac 
reference: #540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen hamen force-pushed the im-463-tuning-textfields-ui branch from d8182f6 to 9f25cf4 Compare August 20, 2024 17:10
hamen added 4 commits August 26, 2024 16:05
@hamen
add example text to Swing TextArea in SwingComparisonTabPanel
3c2a62d 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
fix TextArea cursor start padding
092e328 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
iterate on InputField focused UI
2fe1889 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
iterate on TextField and TextArea style and metrics
85ce910 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
hamen added 14 commits August 26, 2024 16:10
@hamen
reformat IntUiBridge.kt
43440af 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
update API files
c41719f 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
use retrieveArcAsCornerSize instead of manually pulling the constant
75674fd 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
add more textfields to SwingComparisonTabPanel for further comparison
2ae3c30 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
reformat
f9b533f 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
remove detekt-compose dependency from .idea/detect.xml
ca6697b 
reference: #540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
remove redundant parameter in IntUiBridge TextFieldMetrics
d43f2d2 
reference: #540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
remove unnecessary focusOutlineExpand property
0927f74 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
clean up Swing/Compose TextField comparison
ce1750b 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
re-enable logging in ResourcePainterProvider
4f6d990 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
tune TextArea paddings
ffaed20 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
update API files
a44a3e5 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
restore previous minSize for TextField
6b04aef 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
reapply border fixed after scrollbar rebase
e73cef2 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen hamen force-pushed the im-463-tuning-textfields-ui branch from 6dd950c to e73cef2 Compare August 26, 2024 14:27
@hamen
reformat InputField
097b6bf 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen hamen force-pushed the im-463-tuning-textfields-ui branch from a5ac3e1 to 3c2693f Compare August 26, 2024 14:45
@hamen
tune TextFieldMetrics
67a0ba5 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen hamen force-pushed the im-463-tuning-textfields-ui branch from 3c2693f to 67a0ba5 Compare August 26, 2024 14:46
@hamen @rock3r
Tweak paddings to better align with Swing
2d395cd 
* TextField horizontal padding should consider the border, too
* TextArea padding should not apply to the scrollbar itself
* Tweak scrollbar min height to match Swing
@rock3r rock3r enabled auto-merge (squash) August 26, 2024 15:41
@rock3r rock3r merged commit 0816d43 into main Aug 26, 2024
3 checks passed
@rock3r rock3r deleted the im-463-tuning-textfields-ui branch August 26, 2024 15:52
intellij-monorepo-bot pushed a commit to JetBrains/intellij-community that referenced this pull request Nov 29, 2024
@hamen @intellij-monorepo-bot
Iterate on TextField and TextArea focused state UI (#540)
3c5ddf3 
* add example text to Swing TextArea in SwingComparisonTabPanel

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* fix TextArea cursor start padding

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* iterate on InputField focused UI

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* iterate on TextField and TextArea style and metrics

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* reformat IntUiBridge.kt

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* update API files

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* use retrieveArcAsCornerSize instead of manually pulling the constant

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* add more textfields to SwingComparisonTabPanel for further comparison

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* reformat

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* remove detekt-compose dependency from .idea/detect.xml

reference: JetBrains/jewel#540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* remove redundant parameter in IntUiBridge TextFieldMetrics

reference: JetBrains/jewel#540 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* remove unnecessary focusOutlineExpand property

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* clean up Swing/Compose TextField comparison

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* re-enable logging in ResourcePainterProvider

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* tune TextArea paddings

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* update API files

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* restore previous minSize for TextField

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* reapply border fixed after scrollbar rebase

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* reformat InputField

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* tune TextFieldMetrics

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

* Tweak paddings to better align with Swing

* TextField horizontal padding should consider the border, too
* TextArea padding should not apply to the scrollbar itself
* Tweak scrollbar min height to match Swing

---------

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
GitOrigin-RevId: 91e8618ea17a14ebe067d8313df306a86a075d67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rock3r rock3r rock3r approved these changes

Assignees

@hamen hamen

Labels
consistency Our UI presentation is not consistent with IJ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alignment issue with outlined button Ensure TextField and TextArea decoration looks correct
2 participants
@hamen @rock3r