-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated ActionSystem to Compose Traversal API & UiDataProvider API #532
Conversation
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/JewelComposePanel.kt
Show resolved
Hide resolved
...ridge/src/main/kotlin/org/jetbrains/jewel/bridge/actionSystem/ComponentDataProviderBridge.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kuba, can we move the interfaces/modifier definition to the UI package and have a dummy no-op implementation in the standalone package? Otherwise we're creating a bridge-only API.
(I am aware this was only in the bridge to begin with, but it was never really used/supported before, and we're here to change that)
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/JewelComposePanel.kt
Show resolved
Hide resolved
...ridge/src/main/kotlin/org/jetbrains/jewel/bridge/actionSystem/ComponentDataProviderBridge.kt
Show resolved
Hide resolved
...s/ide-plugin/src/main/kotlin/org/jetbrains/jewel/samples/ideplugin/ActionSystemTestAction.kt
Outdated
Show resolved
Hide resolved
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/actionSystem/DataProviderNode.kt
Outdated
Show resolved
Hide resolved
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/JewelComposePanel.kt
Outdated
Show resolved
Hide resolved
0bd0dda
to
6de2103
Compare
6de2103
to
9fe6108
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can confirm the APIs can now be used from standalone code too (they will be no-op, that's fine) this is good to go for me
The api now looks like this:
Let me know if the api can be improved somehow. ComponentDataProviderBridge is no longer public as it requires instance of JewelComposePanel and Swing level nesting. If there is reasonable use-case for this, we can make it public again.