Handle upcoming mill embedded BSP and fix mill BSP install #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joan38
changed the title
jastice
approved these changes
Oct 28, 2020
jastice
requested changes
Oct 29, 2020
| @@ -103,9 +103,6 @@ object bspConfigSteps { | |||
| builder.setPreImportConfig(NoPreImport) | |||
| // server config to be set in next step | |||
| SbtConfigSetup(workspace) | |||
| case bspConfigSteps.MillSetup => | |||
| builder.setPreImportConfig(NoPreImport) | |||
| MillConfigSetup(workspace) | |||
There was a problem hiding this comment.
Taking this case out causes a compile error since we have fatal warnings now. Should it just be an empty case, or the MillSetup object removed?
[error] /Users/jast/workspace/scalaUltimate/community/bsp/src/org/jetbrains/bsp/project/importing/bspConfigSteps.scala:89:12: match may not be exhaustive.
[error] It would fail on the following input: MillSetup
[error] } else configSetup match {
There was a problem hiding this comment.
I pushed a new implementation which is much better actually.
jastice
approved these changes
Oct 30, 2020
|
Thanks @jastice |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BSP support is now integrated in Mill by default.
This PR handle backcompat with older versions of Mill but not super proud of the code. anyway this is temporary and we'll be able to drop all of this when dropping support for older Mill version.
This is also fixing the generation of the bsp config from mill that got broken for some reason.
Thanks