Introduce test for invoking composeCompatibilityBrowserDistribution in heavily reconfigured project #5380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich tests heavily reconfigured project with composeCompatibilityBrowserDistribution
igordmn
approved these changes
Aug 8, 2025
...rc/test/kotlin/org/jetbrains/compose/test/tests/integration/CompatibilityDistributionTest.kt
Outdated
Show resolved
Hide resolved
harrytmthy
reviewed
Aug 8, 2025
Comment on lines
+31
to
+32
| val actualFiles = distributionNames.filterNot { it.endsWith(".wasm") }.toSet() | ||
| assertEquals(expectedFileNames, actualFiles, "files mismatch in $dirPath") |
There was a problem hiding this comment.
NIT: The .wasm check uses any { ... }, which is lenient, while the actualFiles check uses strict assertEquals(...), failing even if there's just one unexpected file (e.g. Untitled.txt).
Should we make both checks consistent in strictness/leniency, depending on whether extra non-.wasm files should be allowed? 🤔
There was a problem hiding this comment.
Hey @harrytmthy ! You're raising valid questions, it's just that we are putting main effort into checking for actual name of the generated artefacts, so this check-for-wasm approach is a temporary trade-off.
Schahen
added a commit
that referenced
this pull request
Aug 22, 2025
…n heavily reconfigured project (#5380) CompatibilityDistributionTest::testWebJsWasmReconfigured makes sure that composeCompatibilityBrowserDistribution task can be reconfigured to be used with arbitrary set of input tasks ## Testing Pipeline ## Release Notes N/A
henryqwe
pushed a commit
to henryqwe/compose-multiplatform
that referenced
this pull request
Oct 1, 2025
…n heavily reconfigured project (JetBrains#5380) CompatibilityDistributionTest::testWebJsWasmReconfigured makes sure that composeCompatibilityBrowserDistribution task can be reconfigured to be used with arbitrary set of input tasks ## Testing Pipeline ## Release Notes N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompatibilityDistributionTest::testWebJsWasmReconfigured makes sure that composeCompatibilityBrowserDistribution task can be reconfigured to be used with arbitrary set of input tasks
Testing
Pipeline
Release Notes
N/A