Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore commonMain to AOSP state (small fixes) #1756

Draft
wants to merge 1 commit into
base: jb-main
Choose a base branch
from

Conversation

igordmn
Copy link
Collaborator

@igordmn igordmn commented Dec 20, 2024

Partially fixes https://youtrack.jetbrains.com/issue/CMP-5740/Upstreaming.-compilation.-other-fixes

Restore to the last merged Jetpack Compose (1.8.0-alpha07) and Material3 (1.4.0-alpha04):

  • restore imports
  • restore file names
  • formatting
  • TODO/comments removed (if we still need them, we should only keep issues)
  • remove unused code

The provided functionality is no longer needed as it is implemented in clickable (discovered in https://youtrack.jetbrains.com/issue/CMP-5750/Upstreaming.-feature.-foundation.-toggle-on-Space)

Testing

  • CI passes

Release Notes

N/A

Partially fixes https://youtrack.jetbrains.com/issue/CMP-5740/Upstreaming.-compilation.-other-fixes

Restore to the last merged Jetpack Compose (1.8.0-alpha07) and Material3 (1.4.0-alpha04):
- restore imports
- restore file names
- formatting
- TODO/comments removed (if we still need them, we should only keep issues)
- remove unused code

The provided functionality is no longer needed as it is implemented in `clickable` (discovered in https://youtrack.jetbrains.com/issue/CMP-5750/Upstreaming.-feature.-foundation.-toggle-on-Space)

## Testing
- CI passes

## Release Notes
N/A
@igordmn igordmn force-pushed the igor.demin/restore-to-aosp-state-small-fixes branch from 96413b5 to e431376 Compare December 20, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant