Introduce WebDragAndDropManager #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
requested changes
Dec 11, 2024
...ose/ui/ui-graphics/src/skikoMain/kotlin/androidx/compose/ui/graphics/SkiaImageAsset.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/jsWasmMain/kotlin/androidx/compose/ui/draganddrop/DragAndDrop.jsWasm.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/draganddrop/WebDragAndDropManager.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/draganddrop/WebDragAndDropManager.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/draganddrop/WebDragAndDropManager.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/window/ComposeWindow.web.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
Dec 11, 2024
MatkovIvan
reviewed
Dec 11, 2024
compose/ui/ui/src/jsWasmMain/kotlin/androidx/compose/ui/draganddrop/DragAndDrop.jsWasm.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
Dec 13, 2024
compose/ui/ui/src/jsWasmMain/kotlin/androidx/compose/ui/draganddrop/DragAndDrop.jsWasm.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
LGTM
please wait @eymar's review for js/web/browser specifics
eymar
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is important to know about this particular PR:
It does not covers dnd data - since it will be covered as a separate PR
It's almost impossible to make reliable unit tests for testing drag and drop so a separate effort will be made to introduce integration tests (which, again, are not part of this particular PR)
The DragAndDropExample will be redone and commonized completely in a separate PR