Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation 1.9.1 #1705

Merged

Conversation

MatkovIvan
Copy link
Member

DO NOT SQUASH! SHOULD BE MERGED MANUALLY

@MatkovIvan MatkovIvan requested review from igordmn and eymar December 3, 2024 12:45
@@ -23,7 +23,7 @@ import com.android.tools.lint.detector.api.CURRENT_API
@Suppress("UnstableApiUsage")
class ExperimentalIssueRegistry : IssueRegistry() {
Copy link
Collaborator

@igordmn igordmn Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get needed changes you seems need to unpin the annotation library

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need them somewhere - yes, sure. But I don't see how it's related to experimental/lint file

Copy link
Collaborator

@igordmn igordmn Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attached my comment to the random line 🫠. I was talking about

replacing

"org.jetbrains.compose.annotation-internal:annotation:1.7.1"

by

project(":annotation:annotation")

In the whole project.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary without an explicit need for it. If we stop publish annotation-internal, it will be a good timing for it. But unpinning is not related to the update version itself.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an explicit need for it

Okay. As far as I remember, this change adds some needed implementation for ìntegration` branch.

If it is needed for it, we can unpin there.

@MatkovIvan MatkovIvan merged commit 2bb8aba into jb-main Dec 9, 2024
7 checks passed
@MatkovIvan MatkovIvan deleted the integration-copy/annotation/eecb9af750b/to-jb-main branch December 9, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants