-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation 1.9.1 #1705
Annotation 1.9.1 #1705
Conversation
@@ -23,7 +23,7 @@ import com.android.tools.lint.detector.api.CURRENT_API | |||
@Suppress("UnstableApiUsage") | |||
class ExperimentalIssueRegistry : IssueRegistry() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get needed changes you seems need to unpin the annotation library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need them somewhere - yes, sure. But I don't see how it's related to experimental/lint
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I attached my comment to the random line 🫠. I was talking about
replacing
"org.jetbrains.compose.annotation-internal:annotation:1.7.1"
by
project(":annotation:annotation")
In the whole project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary without an explicit need for it. If we stop publish annotation-internal
, it will be a good timing for it. But unpinning is not related to the update version itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an explicit need for it
Okay. As far as I remember, this change adds some needed implementation for ìntegration` branch.
If it is needed for it, we can unpin there.
DO NOT SQUASH! SHOULD BE MERGED MANUALLY