Batch frequent Marked Text edit commands #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,23 +125,4 @@ internal interface IOSSkikoInput { | |||
| * Returned value must be in range between 0 and length of text (inclusive). | |||
| */ | |||
| fun positionFromPosition(position: Long, offset: Long): Long | |||
|
|
|||
| object Empty : IOSSkikoInput { | |||
There was a problem hiding this comment.
Yes, It hasn't beed used before as well.
mazunin-v-jb
approved these changes
Nov 27, 2024
igordmn
reviewed
Nov 28, 2024
...e/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/IntermediateTextInputUIView.uikit.kt
Outdated
Show resolved
Hide resolved
igordmn
reviewed
Nov 29, 2024
...e/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/IntermediateTextInputUIView.uikit.kt
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/UIKitTextInputService.uikit.kt
Show resolved
Hide resolved
igordmn
reviewed
Nov 29, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/UIKitTextInputService.uikit.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/UIKitTextInputService.uikit.kt
Show resolved
Hide resolved
...e/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/IntermediateTextInputUIView.uikit.kt
Outdated
Show resolved
Hide resolved
igordmn
approved these changes
Nov 29, 2024
ASalavei
added a commit
that referenced
this pull request
Dec 9, 2024
Add code that joins several frequent text edit commands into a single commands batch. Fixes https://youtrack.jetbrains.com/issue/CMP-6786/when-use-Chinese-keyboard-inputs-get-interrupted. ## Release Notes ### Fixes - iOS - Fixes an interruption while typing characters on a Chinese keyboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code that joins several frequent text edit commands into a single commands batch.
Fixes https://youtrack.jetbrains.com/issue/CMP-6786/when-use-Chinese-keyboard-inputs-get-interrupted.
Release Notes
Fixes - iOS