Prevent CfW-mobile crash when selecting some text in SelectionContainer #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: properly implement Modifier.selectionMagnifier https://youtrack.jetbrains.com/issue/CMP-6645
eymar
changed the title
|
cc: @terrakok After this change, the selection will not crash the app. |
Schahen
approved these changes
Sep 10, 2024
eymar
added a commit
that referenced
this pull request
Sep 10, 2024
…er (#1551) Currently, the web app would crash in mobile browsers after selecting some text in SelectionContainer. This is rather a workaround: we simply do nothing. But it's an acceptable one, since not all android and ios versions support selectionMagnifier anyway. TODO: properly implement Modifier.selectionMagnifier https://youtrack.jetbrains.com/issue/CMP-6645 ## Testing - Added a simple unit test - tested in Google Chrome on my android device ## Release Notes ### Fixes - Web - Prevent a crash on mobile web when selecting some text in SelectionContainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the web app would crash in mobile browsers after selecting some text in SelectionContainer.
This is rather a workaround: we simply do nothing. But it's an acceptable one, since not all android and ios versions support selectionMagnifier anyway.
TODO: properly implement Modifier.selectionMagnifier https://youtrack.jetbrains.com/issue/CMP-6645
Testing
Release Notes
Fixes - Web
SelectionContainer