Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a separate versioning for COMPOSE_MATERIAL3_ADAPTIVE #1500

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

igordmn
Copy link
Collaborator

@igordmn igordmn commented Aug 15, 2024

Also, change the overriding mechanism, now strict name is required

Testing

gradlew :mpp:publishComposeJbToMavenLocal -Pjetbrains.publication.version.COMPOSE=0.1.0 -Pjetbrains.publication.version.COMPOSE_MATERIAL3_ADAPTIVE=0.2.0 -Pjetbrains.publication.libraries=COMPOSE_MATERIAL3_ADAPTIVE

creates .m2\repository\org\jetbrains\compose\material3\adaptive\adaptive\0.2.0 that depends on Compose 0.1.0

Also, change overriding mechanism, now strict name is required

## Testing
```
gradlew :mpp:publishComposeJbToMavenLocal -Pjetbrains.publication.version.COMPOSE=0.1.0 -Pjetbrains.publication.version.COMPOSE_MATERIAL3_ADAPTIVE=0.2.0 -Pjetbrains.publication.libraries=COMPOSE_MATERIAL3_ADAPTIVE
```
creates `.m2\repository\org\jetbrains\compose\material3\adaptive\adaptive\0.2.0` that depends on Compose 0.1.0
@igordmn igordmn requested a review from eymar August 15, 2024 12:40
@eymar
Copy link
Member

eymar commented Aug 15, 2024

Screenshot 2024-08-15 at 15 05 40

for some reason no js, ios variants are published.
Shared this with Kostya.

@eymar
Copy link
Member

eymar commented Aug 15, 2024

nvm. -Pcompose.platforms=all - this was missing and therefore js and ios were not published.

LGTM

@MatkovIvan MatkovIvan dismissed their stale review August 15, 2024 14:31

Not that value

@igordmn igordmn merged commit dc36893 into jb-main Aug 15, 2024
6 checks passed
@igordmn igordmn deleted the igor.demin/material3-adaptive-different-version branch August 15, 2024 14:48
igordmn added a commit that referenced this pull request Aug 15, 2024
Also, change the overriding mechanism, now strict name is required

## Testing
```
gradlew :mpp:publishComposeJbToMavenLocal -Pjetbrains.publication.version.COMPOSE=0.1.0 -Pjetbrains.publication.version.COMPOSE_MATERIAL3_ADAPTIVE=0.2.0 -Pjetbrains.publication.libraries=COMPOSE_MATERIAL3_ADAPTIVE
```
creates
`.m2\repository\org\jetbrains\compose\material3\adaptive\adaptive\0.2.0`
that depends on Compose 0.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants