Forward UIViewController status bar APIs to ComposeUIViewControllerDelegate #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASalavei
approved these changes
May 31, 2024
ASalavei
reviewed
May 31, 2024
| val viewController = LocalUIViewController.current | ||
| LaunchedEffect(statusBarStyleIndex, statusBarHiddenIndex, statusBarAnimationIndex) { | ||
| UIView.animateWithDuration(0.3) { | ||
| viewController.setNeedsStatusBarAppearanceUpdate() |
There was a problem hiding this comment.
Just wondering if we can rework code to get rid of this call when changing status bar appearance settigns.
There was a problem hiding this comment.
We could, but I guess people know exactly when they want to do it, and it's a trivial piece of code, so better not lock ourselves into some specific behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward status bar related APIs to
ComposeUIViewControllerDelegateImplements enhancement requested by JetBrains/compose-multiplatform#4889
Testing
StatusBarStateExampleinDemoproject.Release Notes
Features - iOS
preferredStatusBarStyle,preferredStatysBarAnimationandprefersStatusBarHiddenare added toComposeUIViewControllerDelegateto allow status bar appearance modification.