Align Compose components semantics with UIKit views accessibility (#1719

) Update UIAccessibility properties calculation to align Compose component semantics with the expected UIKit component behaviour. Fixes: https://youtrack.jetbrains.com/issue/CMP-7223/Support-accessibility-semantics-for-various-components Also fixes: https://youtrack.jetbrains.com/issue/CMP-4586/first-element-in-dropdown-does-not-have-a-hitbox-in-iOS-accessibility https://youtrack.jetbrains.com/issue/CMP-4795/Order-of-accessibility-nodes-is-wrong https://youtrack.jetbrains.com/issue/CMP-7209/iOS-Accessibility-doesnt-always-return-isChecked-value-from-radioButton-as-False ## Testing See [CMP-7223](https://youtrack.jetbrains.com/issue/CMP-7223/Support-accessibility-semantics-for-various-components) ## Release Notes ### Features - iOS - Align Compose components semantics with UIKit views accessibility
JetBrains · Dec 13, 2024 · 201bbea · 201bbea
1 parent 304e71b
commit 201bbea
Show file tree

Hide file tree

Showing 5 changed files with 754 additions and 34 deletions.
diff --git a/compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPAccessibilityElement.h b/compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPAccessibilityElement.h
@@ -41,12 +41,18 @@ NS_ASSUME_NONNULL_BEGIN
 
 - (NSString *__nullable)accessibilityValue CMP_ABSTRACT_FUNCTION;
 
+- (__nullable id<UITextInput>)accessibilityTextInputResponder CMP_ABSTRACT_FUNCTION;
+
 - (CGRect)accessibilityFrame CMP_ABSTRACT_FUNCTION;
 
 - (BOOL)isAccessibilityElement CMP_ABSTRACT_FUNCTION;
 
 - (BOOL)accessibilityActivate CMP_ABSTRACT_FUNCTION;
 
+- (void)accessibilityIncrement CMP_ABSTRACT_FUNCTION;
+
+- (void)accessibilityDecrement CMP_ABSTRACT_FUNCTION;
+
 // Private SDK method. Calls when the item is swipe-to-focused in VoiceOver.
 - (BOOL)accessibilityScrollToVisible;
 

diff --git a/compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPAccessibilityElement.m b/compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPAccessibilityElement.m
@@ -80,6 +80,10 @@ - (NSString *__nullable)accessibilityLabel {
     CMP_ABSTRACT_FUNCTION_CALLED
 }
 
+- (__nullable id<UITextInput>)accessibilityTextInputResponder {
+    CMP_ABSTRACT_FUNCTION_CALLED
+}
+
 - (NSString *__nullable)accessibilityValue {
     CMP_ABSTRACT_FUNCTION_CALLED
 }
@@ -96,6 +100,14 @@ - (BOOL)accessibilityActivate {
     CMP_ABSTRACT_FUNCTION_CALLED
 }
 
+- (void)accessibilityIncrement {
+    CMP_ABSTRACT_FUNCTION_CALLED
+}
+
+- (void)accessibilityDecrement {
+    CMP_ABSTRACT_FUNCTION_CALLED
+}
+
 - (BOOL)accessibilityScroll:(UIAccessibilityScrollDirection)direction {
     CMP_ABSTRACT_FUNCTION_CALLED
 }