Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Powerline arrows not rendered #189

Closed
felixse opened this issue Mar 26, 2020 · 13 comments
Closed

Powerline arrows not rendered #189

felixse opened this issue Mar 26, 2020 · 13 comments
Labels
bug Something isn't working

Comments

@felixse
Copy link

felixse commented Mar 26, 2020

image

Arrows are not rendered (just a thin line if you look closely) in Visual Studio Code and Fluent Terminal (both based on xterm.js) since the 1.0.5 update. No problems in Windows Terminal though

Problem still occurs after removing, restarting and reinstalling the font
@philippnurullin philippnurullin added bug Something isn't working and removed bug Something isn't working labels Mar 26, 2020
@philippnurullin
Copy link
Member

@felixse Found this issue. May be related microsoft/vscode#84432
We will try to reproduce and understand what can be done from font perspective.

@william-shuman
Copy link

I'm seeing this same behavior with tilix and gnome-terminal. I'm using powerline10k theme for zsh and after I updated to 1.0.5 the arrows disappeared. It looks like it is trying to use U+EOBO to display the arrow.

@philippnurullin
Copy link
Member

We reproduced the issue. Still don't know what causing it tho but we are looking.
@william-shuman U+EOBO is a correct unicode for the arrow symbol.

@philippnurullin philippnurullin added the bug Something isn't working label Apr 1, 2020
@qiaojunfeng
Copy link

I am experiencing the same issue, recent update breaks powerline right arrow.
For other fonts, this right arrow can correctly render.

@philippnurullin
Copy link
Member

We found whats causing this bug. Expect fix in v1.0.6 at first half of next week.
For now you can go back to v1.0.4 https://github.com/JetBrains/JetBrainsMono/releases/tag/v1.0.4
Thanks for patience.

philippnurullin added a commit that referenced this issue Apr 8, 2020
@philippnurullin
v1.0.6
5753521 
— Fixed problem with disappeared Powerline arrows #189
— Added U+0336 #190
— Added >-> Ligature #194
— Fixed rendering problems with arrow in ligatures #196
— Added exclusion in ligatures with -- --- to treat loading #151
— Added source files in .ufo format
@philippnurullin philippnurullin mentioned this issue Apr 9, 2020
Closed
@philippnurullin philippnurullin mentioned this issue Apr 27, 2020
Closed
philippnurullin added a commit that referenced this issue Apr 29, 2020
@philippnurullin
v1.0.6
4dd35ad 
Major changes
— Fixed problems with rendering of Powerline symbols #189
— Added support of Vietnamese language #14 #209
— All diacritics redone. Corrected a bunch of problems of placing & more balanced mass.
— Added DesignSpace+UFO source files. Just converted & dumped as they are, for now. There are issues with Masters compatibility. Tested in Glyphs app.

Other fixes
— Fixed construction of † ‡ ∏ ∐  #205 #206
— Added exclusion in /* ligature #88
— Refactored ß
— ~= ligature removed #204
— Added >-> ligature #194
— Added u0336 Long stroke overlay #190
— Added ligature //= #185
— Corrected contour of the arrows in ligatures #196

Known issues
— In Medium weights the height of [ ] { } decreased by one pixel in 12px, 13px sizes. This is a hinting bug.
@philippnurullin
Copy link
Member

Please try v1.0.6. Feel free to reopen this issue if problem persists.

@felixse
Copy link
Author

felixse commented Apr 30, 2020

VS Code:
image

The arrows are rendering now, but the branch symbol is missing and the arrows seem to be a bit shorter than the row height. Also some line artefact line in VS Code.

Windows Terminal:
image

Branch symbol is showing up here, but arrow still missing some height.

@philippnurullin
Copy link
Member

Thanks for the update.

  1. The line between the arrow. Will be fixed in the next update.
  2. The 100% correct arrow placement by vertical axis. I don't think it's possible. The yellow zone is not a glyph so it renders a bit different in different editors.

But i have an idea. What Line height you have in VS code terminal?
You can search the settings.json for "terminal.integrated.lineHeight"

@felixse
Copy link
Author

felixse commented Apr 30, 2020

terminal.integrated.lineHeight is 1

Any idea why the branch symbol is missing? Looks like the initial bug, but this time only this symbol is affected

@philippnurullin
Copy link
Member

I have a theory, that the contour of branch symbol is collapsing because of the incorrect line height. When the line height is too small it causing the bug. Why it happens is beyond my understanding but first we need to confirm it.

Ok, can you set the line height to 20 for the experiment?

@felixse
Copy link
Author

felixse commented Apr 30, 2020

line height is a multiplicator for font size and only affects the background. But I tried font sizes from 10 to 20 and the symbol never showed up

@philippnurullin
Copy link
Member

It's a shame.
Please send the OS, VS code version, we will try to reproduce & experiment more.

@felixse
Copy link
Author

felixse commented Apr 30, 2020

Thanks for looking into this. Regardless of this I'm really enjoying the font 😃

Windows 10 Enterprise Version 1909 Build 18363.815
Visual Studio Code 1.44.2

@hexchain hexchain mentioned this issue May 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@william-shuman @qiaojunfeng @felixse @philippnurullin