Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity update event test #763

Closed
wants to merge 4 commits into from
Closed

Entity update event test #763

wants to merge 4 commits into from

Conversation

mpe85
Copy link
Contributor

@mpe85 mpe85 commented Jan 8, 2020

No description provided.

@mpe85 mpe85 mentioned this pull request Jan 8, 2020
Closed
@Tapac
Copy link
Contributor

Tapac commented Jan 11, 2020

@mpe85 , once again thank you for a PR which reveals a problem.
I had migrated your code to EntityHookTest.kt and fix a bug.
I'll close that PR.

@Tapac Tapac closed this Jan 11, 2020
@mpe85
Copy link
Contributor Author

mpe85 commented Jan 11, 2020

@Tapac I just saw you changed the way how events are fired: d211400
Since they are now fired immediately the subscribers will receive the events also when the transaction is rolled back, am I right? Before that commit events were only fired on transaction commit.
I am asking because my code relies on events not being fired on transaction rollback.

@Tapac
Copy link
Contributor

Tapac commented Jan 13, 2020

@mpe85, thank you, it makes sense.
The main idea behind it was to notify user in the time event happens. For example, you want to create related entities when some other entity was created.

I'll revert the change and will think about how to cover both cases and do not break existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpe85 @Tapac