Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Clientside length validation in ColumnType breaks otherwise harmless where clause #1204

Closed
spand opened this issue Apr 13, 2021 · 1 comment

Comments

@spand
Copy link
Contributor

spand commented Apr 13, 2021

Commit ffcc91a introduced client side validation of values and it now breaks otherwise harmless where clauses. This has already been noted by comments on #993.

I am not sure I agree that this should happen client side (now the database and exposed table objects can no longer diverge.. something really useful in migrations ops-wise). If anything it seems to relate to a lack of support in Postgres which seems to make the case that it should be a dialect specific behavior instead.

One might think this could then be fixed by constant folding the where clauses to avoid calling notNullValueToDB with an invalid value but I dont think its that easy.

Tapac added a commit that referenced this issue May 9, 2021
…se harmless where clause #1204

select query throws "can't be stored to database column because exceeds length" #1222
@Tapac
Copy link
Contributor

Tapac commented May 9, 2021

Thank you for the report. The validation moved to a separate function and will be executed only on updates/inserts.

@Tapac Tapac closed this as completed May 9, 2021
SchweinchenFuntik pushed a commit to SchweinchenFuntik/Exposed that referenced this issue Oct 23, 2021
…se harmless where clause JetBrains#1204

select query throws "can't be stored to database column because exceeds length" JetBrains#1222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants