Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatible with nacos 2.2.0 #21

Merged
merged 1 commit into from
Feb 18, 2023
Merged

Fix compatible with nacos 2.2.0 #21

merged 1 commit into from
Feb 18, 2023

Conversation

khotyn
Copy link
Contributor

@khotyn khotyn commented Feb 18, 2023 •
edited
Loading

Fix nacos 2.2.0 compatibility and print standard output and error stream if nacos failed to start.

Fix #20

@height
Copy link

height bot commented Feb 18, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

JervyShi
JervyShi approved these changes Feb 18, 2023
View reviewed changes
Copy link
Owner

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JervyShi JervyShi merged commit 7a2abc0 into JervyShi:master Feb 18, 2023
@JervyShi JervyShi added this to the 0.3.0 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JervyShi JervyShi JervyShi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Failed to start nacos 2.2.0
2 participants
@khotyn @JervyShi