Prevent endless loop when duplicating product

Remove redundant backward compatibility in constructor
JeroenVanLeusden · Feb 4, 2020 · a027e87 · a027e87
1 parent 8e2959d
commit a027e87
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/code/Magento/Catalog/Model/Product/Copier.php b/app/code/Magento/Catalog/Model/Product/Copier.php
@@ -59,14 +59,14 @@ public function __construct(
         CopyConstructorInterface $copyConstructor,
         ProductFactory $productFactory,
         ScopeOverriddenValue $scopeOverriddenValue,
-        OptionRepository $optionRepository = null,
-        MetadataPool $metadataPool = null
+        OptionRepository $optionRepository,
+        MetadataPool $metadataPool
     ) {
         $this->productFactory = $productFactory;
         $this->copyConstructor = $copyConstructor;
         $this->scopeOverriddenValue = $scopeOverriddenValue;
-        $this->optionRepository = $optionRepository ?: ObjectManager::getInstance()->get(OptionRepository::class);
-        $this->metadataPool = $metadataPool ?: ObjectManager::getInstance()->get(MetadataPool::class);
+        $this->optionRepository = $optionRepository;
+        $this->metadataPool = $metadataPool;
     }
 
     /**