Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Dockerfile #14

wants to merge 1 commit into from

Conversation

fixdocker
Copy link

Hello, I represent a research group investigating build failures in
Dockerfiles. We executed a Dockerfile in your project and found that
it is not building. We are sending this Pull Request with a suggested
repair. The repair operation is based on the following URL:

Please note that we are using an anonymous GitHub account because of
double-blind restrictions in the submission process of conferences.

@fixdocker
Copy link
Author

Hey @JensErat @rwky , can you check this PR?

@rwky
Copy link
Contributor

rwky commented Aug 9, 2020

I've not used selfoss in some time but looking at the repo it'd be better to upgraded to a supported PHP version (ideally 7.4)

@fixdocker
Copy link
Author

fixdocker commented Aug 10, 2020

@rwky, we have changed the base image to php: 7.4-apache, and after that we also noticed problems with the docker-php-ext configuration so we changed from --with-jpeg-dir= to --with-jpeg=[1] and remove mbstring[2] , and this fixed it. Can we submit a new pull request with these changes?

[1] - docker-library/php#931 (comment)
[2] - https://stackoverflow.com/a/59253249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants