Skip to content

Commit

Permalink
[Frontend] Fix the TFMA/TFDV viz behavior when caching is used. (kube…
Browse files Browse the repository at this point in the history
…flow#3228)

* include cached execution

* apply suggestion

* typo fix

* lint

* improve style

* fix typo

* fix
  • Loading branch information
Jiaxiao Zheng authored and Jeffwan committed Dec 9, 2020
1 parent 64f7daf commit 8b648e1
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions frontend/src/lib/OutputArtifactLoader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -472,10 +472,12 @@ async function getExecutionInContextWithPodName(
return undefined; // Not found, this is expected to happen normally when there's no mlmd data.
}
const state = foundExecution.getPropertiesMap().get('state');
if (!state || state.getStringValue() !== 'complete') {
return undefined; // Execution doesn't have a valid state, or it has not finished.
// Both complete and cached executions are considered valid.
if (state && ['complete', 'cached'].includes(state.getStringValue())) {
return foundExecution;
}
return foundExecution;
// No valid execution found.
return undefined;
}

/**
Expand Down

0 comments on commit 8b648e1

Please sign in to comment.