Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring and encapsulation of constants, add .gitignore #570

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

mags0ft
Copy link
Contributor

@mags0ft mags0ft commented Feb 24, 2025

Hello and good day,

I refactored a small amount of repeating code and constants and encapsulated these values in their new, own constants.py file - a file where everything that's related to non-changing values can be placed, so if something changes in the future, there's one central place to consult and edit!

For example, you do now have this handy Platforms class that keeps track of the sys.platform values of the platforms that aren't yet fully supported. Once every single feature works on macOS for example, you can simply remove it from the ported tuple and it'll be reflected in all of Alpaca.

image

Translators are also no longer in the main.py file but rather in the constants.py file, where they are in a more encapsulated space.

image

I also added a .gitignore file that allows other editors than GNOME Builder to work with the project more seamlessly.

Last but not least, I re-organized the imports of the files I edited.

Best greets! :)

@Jeffser
Copy link
Owner

Jeffser commented Feb 24, 2025

Aight Thanks

@Jeffser Jeffser merged commit f2bb863 into Jeffser:main Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants