Fix foreign constraint issue

When using the RefreshDatabase trait, the foreign constraint for
best_reply_id wasn’t working properly. Can’t figure out why.

Switching to the DatabaseMigrations trait did the trick.

app/Reply.php

@@ -43,12 +43,6 @@ protected static function boot()
             $reply->owner->gainReputation('reply_posted');
         });
 
-        static::deleting(function ($reply) {
-            if ($reply->isBest()) {
-                $reply->thread->unsetBestReply();
-            }
-        });
-
         static::deleted(function ($reply) {
             $reply->thread->decrement('replies_count');
 

app/Thread.php

@@ -261,17 +261,6 @@ public function markBestReply(Reply $reply)
         $reply->owner->gainReputation('best_reply_awarded');
     }
 
-    /**
-     * Unset best reply from thread.
-     */
-    public function unsetBestReply()
-    {
-        if ($this->hasBestReply()) {
-            $this->bestReply->owner->loseReputation('best_reply_awarded');
-            $this->update(['best_reply_id' => null]);
-        }
-    }
-
     /**
      * Determine if the thread has a current best reply.
      *

tests/Feature/BestReplyTest.php

@@ -3,14 +3,14 @@
 namespace Tests\Feature;
 
 use Tests\TestCase;
-use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Foundation\Testing\DatabaseMigrations;
 
 class BestReplyTest extends TestCase
 {
-    use RefreshDatabase;
+    use DatabaseMigrations;
 
     /** @test */
-    function a_thread_creator_may_mark_any_reply_as_the_best_reply()
+    public function a_thread_creator_may_mark_any_reply_as_the_best_reply()
     {
         $this->signIn();
 
@@ -26,7 +26,7 @@ function a_thread_creator_may_mark_any_reply_as_the_best_reply()
     }
 
     /** @test */
-    function only_the_thread_creator_may_mark_a_reply_as_best()
+    public function only_the_thread_creator_may_mark_a_reply_as_best()
     {
         $this->withExceptionHandling();
 
@@ -44,7 +44,7 @@ function only_the_thread_creator_may_mark_a_reply_as_best()
     }
 
     /** @test */
-    function if_a_best_reply_is_deleted_then_the_thread_is_properly_updated_to_reflect_that()
+    public function if_a_best_reply_is_deleted_then_the_thread_is_properly_updated_to_reflect_that()
     {
         $this->signIn();