Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JFactory "REGENERATE" flag #285

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Add JFactory "REGENERATE" flag #285

merged 3 commits into from
Apr 16, 2024

Conversation

nathanwbrei
Copy link
Collaborator

This tells JFactory::Create() to clear any Insert()ed data and recompute it using JFactory::Process(). This is necessary for certain factories in halld_recon.

This PR also includes several small cleanup operations:

  • Fixes warnings about std::exception being caught by value. These are in a header file that only gets used in halld_recon.
  • Renames JFactoryT::GetOrCreate() to JFactoryT::CreateAndGetData()

The new name more accurately reflects the relationship between Get() and Create(). The caching logic always lives inside Create(), so that untyped retrievals via podio::Frame or JFactoryT::GetAs behave consistently.
@nathanwbrei nathanwbrei requested a review from RaiqaRasool April 15, 2024 19:52
@nathanwbrei nathanwbrei merged commit 14f7029 into master Apr 16, 2024
3 checks passed
@nathanwbrei nathanwbrei deleted the nbrei_gluex_fixes branch April 16, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant