Skip to content

Commit

Permalink
Rename JComponent::Parameter::Configure() to Init()
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanwbrei committed Jan 28, 2025
1 parent 87ad1bc commit 3375883
Show file tree
Hide file tree
Showing 10 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions src/libraries/JANA/Components/JComponent.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class JComponent::ParameterRef : public JComponent::ParameterBase {

protected:

void Configure(JParameterManager& parman, const std::string& prefix) override {
void Init(JParameterManager& parman, const std::string& prefix) override {
if (m_is_shared || prefix.empty()) {
parman.SetDefaultParameter(this->m_name, *m_data, this->m_description);
}
Expand Down Expand Up @@ -76,7 +76,7 @@ class JComponent::Parameter : public JComponent::ParameterBase {

protected:

void Configure(JParameterManager& parman, const std::string& prefix) override {
void Init(JParameterManager& parman, const std::string& prefix) override {
if (m_is_shared || prefix.empty()) {
parman.SetDefaultParameter(this->m_name, m_data, this->m_description);
}
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/JANA/Components/JComponentFwd.h
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ struct JComponent {
const std::string& GetDescription() { return m_description; }
bool IsShared() { return m_is_shared; }

virtual void Configure(JParameterManager& parman, const std::string& prefix) = 0;
virtual void Init(JParameterManager& parman, const std::string& prefix) = 0;
virtual void Wire(const std::map<std::string, std::string>& isolated, const std::map<std::string, std::string>& shared) = 0;
};

Expand Down
2 changes: 1 addition & 1 deletion src/libraries/JANA/Components/JOmniFactory.h
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ class JOmniFactory : public JMultifactory, public jana::components::JHasInputs {

void Init() override {
for (auto* parameter : m_parameters) {
parameter->Configure(*(m_app->GetJParameterManager()), m_prefix);
parameter->Init(*(m_app->GetJParameterManager()), m_prefix);
}
for (auto* service : m_services) {
service->Fetch(m_app);
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/JANA/JEventFolder.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class JEventFolder : public jana::components::JComponent,
}
// TODO: Obtain overrides of collection names from param manager
for (auto* parameter : m_parameters) {
parameter->Configure(*(m_app->GetJParameterManager()), m_prefix);
parameter->Init(*(m_app->GetJParameterManager()), m_prefix);
}
for (auto* service : m_services) {
service->Fetch(m_app);
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/JANA/JEventProcessor.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class JEventProcessor : public jana::components::JComponent,
virtual void DoInitialize() {
std::lock_guard<std::mutex> lock(m_mutex);
for (auto* parameter : m_parameters) {
parameter->Configure(*(m_app->GetJParameterManager()), m_prefix);
parameter->Init(*(m_app->GetJParameterManager()), m_prefix);
}
for (auto* service : m_services) {
service->Fetch(m_app);
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/JANA/JEventSource.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ void JEventSource::DoInit() {
throw JException("Attempted to initialize a JEventSource that is already initialized!");
}
for (auto* parameter : m_parameters) {
parameter->Configure(*(m_app->GetJParameterManager()), m_prefix);
parameter->Init(*(m_app->GetJParameterManager()), m_prefix);
}
for (auto* service : m_services) {
service->Fetch(m_app);
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/JANA/JEventUnfolder.h
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class JEventUnfolder : public jana::components::JComponent,
}
// TODO: Obtain overrides of collection names from param manager
for (auto* parameter : m_parameters) {
parameter->Configure(*(m_app->GetJParameterManager()), m_prefix);
parameter->Init(*(m_app->GetJParameterManager()), m_prefix);
}
for (auto* service : m_services) {
service->Fetch(m_app);
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/JANA/JFactory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void JFactory::DoInit() {
return;
}
for (auto* parameter : m_parameters) {
parameter->Configure(*(m_app->GetJParameterManager()), m_prefix);
parameter->Init(*(m_app->GetJParameterManager()), m_prefix);
}
for (auto* service : m_services) {
service->Fetch(m_app);
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/JANA/JMultifactory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,13 @@ void JMultifactory::DoInit() {
if (m_status != Status::Uninitialized) {
throw JException("Attempted to initialzie a JMultifactory that has already been initialized!");
}
CallWithJExceptionWrapper("JMultifactory::Init", [&](){ Init(); });
for (auto* parameter : m_parameters) {
parameter->Configure(*(m_app->GetJParameterManager()), m_prefix);
parameter->Init(*(m_app->GetJParameterManager()), m_prefix);
}
for (auto* service : m_services) {
service->Fetch(m_app);
}
CallWithJExceptionWrapper("JMultifactory::Init", [&](){ Init(); });
m_status = Status::Initialized;
}

Expand Down
2 changes: 1 addition & 1 deletion src/libraries/JANA/JService.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ void JService::DoInit(JServiceLocator* sl) {
m_logger = params->GetLogger(GetLoggerName());

for (auto* parameter : m_parameters) {
parameter->Configure(*params, m_prefix);
parameter->Init(*params, m_prefix);
}

for (auto* service : m_services) {
Expand Down

0 comments on commit 3375883

Please sign in to comment.