Read swing angle ranges from device #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airblader
force-pushed
the
swing-angle-ranges-from-device
branch
from
0de3cd1
to
b32985b
Compare
Airblader
force-pushed
the
swing-angle-ranges-from-device
branch
from
b32985b
to
9a02a3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads the proper horizontal and vertical swing angle ranges from the API's device details, rather than relying on the hard-coded per-model (prefix) information; though the latter is still used as a fallback for devices that do not report this (you never know, I suppose).
fixes #106
fixes #150
fixes #173
relates #157
In a second commit I am also overwriting the ranges for oscillation, as they should be the same ones.
relates #106
relates #115