Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some initial tests for heaters #167

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Some initial tests for heaters #167

merged 1 commit into from
Aug 26, 2024

Conversation

andy-cooper
Copy link
Contributor

No description provided.

@andy-cooper
Copy link
Contributor Author

@JeffSteinbok some tests for you

@JeffSteinbok
Copy link
Owner

Approved. Note it's not great practice to LOG and then Raise an error. Just raise the error.

@JeffSteinbok JeffSteinbok merged commit 736aca5 into JeffSteinbok:main Aug 26, 2024
3 checks passed
@andy-cooper
Copy link
Contributor Author

Agreed. I was following your lead here:

hass-dreo/custom_components/dreo/pydreo/pydreofan.py

Line 158 in 736aca5

raise ValueError(f"fan_speed must be between {self._speed_range[0]} and {self._speed_range[1]}")

@JeffSteinbok
Copy link
Owner

JeffSteinbok commented Aug 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy-cooper @JeffSteinbok