Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Crash when where is no internet connection available on host machine #21

Closed
panthernet opened this issue Feb 27, 2019 · 2 comments
Closed

[FIX] Crash when where is no internet connection available on host machine #21

panthernet opened this issue Feb 27, 2019 · 2 comments
Labels
ready for next release

Comments

@panthernet
Copy link

Sorry have no possibility to make a pull right now.
Location: XbrlSchema.cs line 184
Problem code:
if(webResponse.StatusCode == HttpStatusCode.NotFound)

You have to check webResponse for null or it will crash in the described case.
FInal fix should be:
if(webResponse == null || webResponse.StatusCode == HttpStatusCode.NotFound)
@JeffFerguson
Copy link
Owner

Thank you for the report! Should be an easy fix that I can make this weekend.

@cjundt cjundt mentioned this issue Oct 25, 2019
Merged
@cjundt
Copy link
Contributor

cjundt commented Oct 29, 2019

Fixed in pull request #32.

JeffFerguson added a commit that referenced this issue Dec 21, 2019
@JeffFerguson
Merge pull request #32 from cjundt/fix21
0314914 
Fixes null reference exception. Fixes #21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ready for next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JeffFerguson @panthernet @cjundt