Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up custom :menuRenderer example to use react-virtualized-select HOC #862

Merged
merged 3 commits into from
Apr 6, 2016

Conversation

bvaughn
Copy link
Collaborator

@bvaughn bvaughn commented Apr 2, 2016

A live version of this PR can be seen here: http://bvaughn.github.io/react-select/

With PR #859 merged and v1.0.0-beta12 released, I released a new HOC- react-virtualized-select- so that I can take on the ownership of maintaining an interface between react-select and react-virtualized. A demo of the HOC can be seen here: http://bvaughn.github.io/react-virtualized-select/

This PR updates the example to use that HOC. (I think it's the simplest way to integrate the 2 libraries so it seems like the way we should show in a demo.)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.011% when pulling b85becf on bvaughn:master into 5c565b8 on JedWatson:master.

@bvaughn bvaughn changed the title Fixed virtualized demo scrolling on iOS and touch devices Cleaned up custom :menuRenderer example to use react-virtualized-select HOC Apr 2, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.011% when pulling 95367e7 on bvaughn:master into 5c565b8 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.011% when pulling 1492b1e on bvaughn:master into 5c565b8 on JedWatson:master.

@omgaz
Copy link
Contributor

omgaz commented Apr 5, 2016

LGTM, just update to the project contrib coding conventions specifically spacing. https://github.com/keystonejs/keystone/wiki/Coding-Standards

@bvaughn
Copy link
Collaborator Author

bvaughn commented Apr 5, 2016

Hi @omgaz. I'm not sure I understand. Are you suggesting I change from tabs to spaces? I attempted to follow the default used in the other files.

@omgaz
Copy link
Contributor

omgaz commented Apr 5, 2016

Hey, sorry my bad mis-read the contrib. Statement retracted! LGTM 🍥

@JedWatson
Copy link
Owner

Thanks @bvaughn! looks great.

@JedWatson JedWatson merged commit 2877726 into JedWatson:master Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants