use wrapper instead of control #467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,10 +187,10 @@ var Select = React.createClass({ | |||
| return; | |||
| } | |||
| var menuElem = React.findDOMNode(_this.refs.selectMenuContainer); | |||
| var controlElem = React.findDOMNode(_this.refs.control); | |||
| var wrapperElem = React.findDOMNode(_this.refs.control); | |||
There was a problem hiding this comment.
I have the same issue and your solution work for me. Just a small typo issue. I think you wanted to get reference to the _this.refs.wrapper instead of _this.refs.control
|
BTW @bezreyhan do you know what is the timeline for merging this pull request? |
|
Sorry this never got attended to. With the release of 1.0.0 I'm closing a lot of old PRs and Issues that either may be fixed / or won't be fixed given the major changes since. Please re-open if you still want to address this in the latest version. Thanks! |
This was referenced Mar 7, 2021
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our select components are designed so that the menu covers the control when the menu is open. This entails changing the css of
.Select-menu-outerto have a top of0px.However, when we make that change the menu doesn't open. It flickers but remains closed. I noticed that the menu will close if the user clicks outside of the
.Select-control. I'm not sure why, but if the menu covers the control, when the user clicks on the control to open the menu theevent.target===Select.wrapperThis means that the menu will never open because the event will always occur outside of the control since it is occurring in the wrapper.