Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add access to portal menu wrapper via classname #4385

Closed

Conversation

G07cha
Copy link

@G07cha G07cha commented Jan 19, 2021

Currently it's quite tricky to style portal wrapper when using classNamePrefix and classes for styling, this commit adds 'menu-portal' suffix to the content wrapper

Currently it's quite tricky to style portal wrapper when using classNamePrefix and classes for styling, this commit adds 'menu-portal' suffix to the content wrapper
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2021

⚠️ No Changeset found

Latest commit: 54e3ecd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 54e3ecd:

Sandbox Source
react-codesandboxer-example Configuration

@ebonow
Copy link
Collaborator

ebonow commented Jan 19, 2021

Greetings @G07cha ,

Thank you for your submission, however, these changes are duplicated by an existing PR #4342 that is scheduled for release v3.3

className={cx(
{
'menu-portal': true,
},
className
)}

@ebonow ebonow closed this Jan 19, 2021
@G07cha G07cha deleted the feat/add-classname-to-menu-portal branch January 20, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants