Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11yText DOM structure fix (breaking W3C validation) #3964

Merged
merged 1 commit into from
Aug 27, 2020
Merged

A11yText DOM structure fix (breaking W3C validation) #3964

merged 1 commit into from
Aug 27, 2020

Conversation

anthonyvialleton
Copy link

Step to reproduce :

W3C errors output :

Error: Element p not allowed as child of element span in this context. (Suppressing further errors from this subtree.)

From line 286, column 54071; to line 286, column 54099

a11yText"><p id="aria-selection-event">&nbsp;

Contexts in which element p may be used:
Where flow content is expected.
Content model for element span:
Phrasing content.
Error: Element p not allowed as child of element span in this context. (Suppressing further errors from this subtree.)

From line 286, column 54134; to line 286, column 54154

ected.</p><p id="aria-context">&nbsp;

W3C is breaking because of A11yText of type span wrapping p elements.

W3C was breaking because of A11yText span wrapping p elements.
@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2020

💥 No Changeset

Latest commit: 1f965ab

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f965ab:

Sandbox Source
react-codesandboxer-example Configuration
react-codesandboxer-example PR

@iorrah
Copy link

iorrah commented Mar 23, 2020

Hey @JedWatson can we look into this PR?

@bladey bladey added pr/priority PRs that should be addressed sooner rather than later pr/needs-review PRs that need to be reviewed to determine outcome and removed pr/priority PRs that should be addressed sooner rather than later labels May 26, 2020
@bladey bladey added category/accessibility Issues or PRs related to accessibility pr/bug-fix PRs that are specifically addressing a bug pr/in-review PRs currently in review by maintainers for the next release and removed pr/needs-review PRs that need to be reviewed to determine outcome labels Jun 4, 2020
@bladey bladey requested review from bladey and JedWatson June 4, 2020 03:27
@bladey
Copy link
Contributor

bladey commented Jun 4, 2020

@JedWatson looks good to me - for your review.

@JedWatson
Copy link
Owner

Thanks for the fix @iorrah - will be released shortly

@JedWatson JedWatson merged commit 397e953 into JedWatson:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/accessibility Issues or PRs related to accessibility pr/bug-fix PRs that are specifically addressing a bug pr/in-review PRs currently in review by maintainers for the next release pr/priority PRs that should be addressed sooner rather than later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants