-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marked deprecated react lifecycles as UNSAFE_* #3716
Conversation
Please merge this. These warnings have been around for ages, and they mask real ones that need attention. |
@JedWatson Would be great to have this one merged. |
@jossmac - You seem to be the last active dev on this repo of late. Is there any chance we can get this PR merged in please? |
Also tagging @gwyneplaine as this seems affecting a lot of developers now |
@rj-david this looks good, thanks for doing this 👌 |
Thank you @gwyneplaine ! |
I'm sorry, but I can't help but feel that this is the wrong approach. Instead these method calls should be replaced with the newer recommended way of doing things. What is going on with this project? Is it even actively maintained? Simple things like this take ages to get patched. |
@mvestergaard, feel free to do the right approach and submit the PR. I'm fully supporting that move |
@gwyneplaine can we make a release for this? |
@JedWatson @jossmac can we get an NPM release for this? All these people will be grateful: |
@rj-david @gwyneplaine There's a 6-month old open PR for the proper fix for this: #3487 |
@saboya fantastic. Will check it once I get the chance. We now have a couple of options:
|
apologies for the delay everyone, this has now been published as part of 3.0.5 |
@gwyneplaine the lib still has this problem: https://github.com/JedWatson/react-input-autosize needs to be fixed too |
UNSAFE_ aliases were added to React in 16.3.0, is there any other prs to make the lib compatible with React 16.0.0 - 16.2.x ? |
As a quick fix to remove the warnings starting react 16.9.0, this marked the deprecated react lifecycles as UNSAFE_*
(Note that this is just to remove the warning. There is still a need to refactor this code to move the code from the deprecated lifecycles to the correct lifecycles - and maybe change some logic)